Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Tab colors with its own variables #3274

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Update Tab colors with its own variables #3274

merged 1 commit into from
Jul 18, 2019

Conversation

mfrecchiami
Copy link
Contributor

@mfrecchiami mfrecchiami commented Jul 17, 2019 •
edited
Loading

Avoid using navbar variables and general variables color, about Tabs.
Dedicated variables has been added.

This is necessary to fix the color of the active tab item, and to avoid such mistakes on the future.

white_color

The right view:

corrected_view

@mfrecchiami
Update Tab colors with its own variables
fa2bd2e 
Avoid using navbar variables and general variables color, about Tabs.
Dedicated variables has been added.
tvdeyen
tvdeyen approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes absolute sense. Please more of this. Thank you 🎉

kennyadsl
kennyadsl approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mfrecchiami

spaghetticode
spaghetticode approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfrecchiami thank you for the fix 👍

@kennyadsl
Copy link
Member

The build is actually 🍏 https://circleci.com/workflow-run/a6e7a7cc-2124-40aa-8f8c-8e4037660a97

@kennyadsl kennyadsl added changelog:solidus_backend Changes to the solidus_backend gem type:bug Error, flaw or fault Need Backport labels Jul 17, 2019
@kennyadsl kennyadsl merged commit 7ff5885 into solidusio:master Jul 18, 2019
@mfrecchiami mfrecchiami mentioned this pull request Jul 25, 2019
Closed
@kennyadsl kennyadsl deleted the mfrecchiami/tabs-variables-color branch August 7, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
changelog:solidus_backend Changes to the solidus_backend gem type:bug Error, flaw or fault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mfrecchiami @kennyadsl @tvdeyen @spaghetticode